Release 2.4.0 #97
Merged
Release 2.4.0 #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I noticed this PR has been inactive for a while. Just wondering if there’s anything blocking it from being merged. |
notgull
approved these changes
Jun 21, 2025
|
CI is broken so we need to address that first. |
|
🤔 Why is it broken? All checks are successful in this pull request. |
|
At the time this PR was submitted it was fine, but the CI on the master branch is broken (https://github.com/smol-rs/async-process/actions/runs/15802408152) and we need to address that before we merge this in. The fix has been determined (smol-rs/async-io#230 (comment)), but it will take some work. |
|
Thanks for the explanation. |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
tracingfeature. When enabled, this feature adds loggingto the implementation. By default it is disabled. (Make tracing optional & fix CI failure & update CI config #101)
async-signal. (Fix target-specific feature flags for rustix dependency #96)windows-systo v0.60. (Update windows-sys requirement from 0.59 to 0.60 #99)